normalize-select-options.test.ts

normalize-select-options.test.tsapps/api/src/modules/databases/__tests__/normalize-select-options.test.tsraw ← __tests__3,403 B← Back to the app
1/**
2 * Select/status/multi-select option-id normalization (bug: the AI generation
3 * path emitted `config.options` as bare `{ name, color }` — no `id` — and
4 * stored record values as the option NAME. Every id-based reader (web chips,
5 * preselect, board grouping, filters) then failed to resolve the value).
6 *
7 * `normalizeSelectOptions` assigns a DETERMINISTIC id (`optionIdForName`) to
8 * any option that lacks one, at the write boundary (create/update property)
9 * and, defensively, on read. It is pure + idempotent — unit-tested here.
10 */
11import { describe, expect, it } from "vitest";
12import { optionIdForName } from "@factory/ai";
13import { normalizeSelectOptions } from "../database.service.js";
14 
15describe("normalizeSelectOptions (select option-id backfill)", () => {
16  it("assigns a deterministic id to options that lack one", () => {
17    const out = normalizeSelectOptions({
18      options: [
19        { name: "To Do", color: "default" },
20        { name: "In Progress", color: "blue" },
21        { name: "Done", color: "green" }
22      ]
23    }) as { options: { id: string; name: string }[] };
24    expect(out.options.map((o) => o.id)).toEqual([
25      optionIdForName("To Do"),
26      optionIdForName("In Progress"),
27      optionIdForName("Done")
28    ]);
29    // The names + colors are preserved verbatim.
30    expect(out.options[0]).toEqual({ name: "To Do", color: "default", id: optionIdForName("To Do") });
31  });
32 
33  it("leaves already-id'd options untouched (idempotent)", () => {
34    const id = optionIdForName("To Do");
35    const cfg = { options: [{ id, name: "To Do", color: "default" }] };
36    const out = normalizeSelectOptions(cfg) as { options: { id: string }[] };
37    expect(out.options[0].id).toBe(id);
38    // Second pass is a no-op (no new object).
39    expect(normalizeSelectOptions(cfg)).toBe(cfg);
40  });
41 
42  it("keeps the ids of PRESENT options on a partial update patch (existing values stay resolvable)", () => {
43    // The stored property already has `To Do` → deterministic id and
44    // `Blocked` → a CUSTOM id. A patch that re-lists BOTH without ids must
45    // reuse each option's existing id (so existing `{ optionId }` values keep
46    // resolving), and a NEW option gets the deterministic name-derived id.
47    const existing = [
48      { id: optionIdForName("To Do"), name: "To Do" },
49      { id: "opt-custom-blocked", name: "Blocked" }
50    ];
51    const out = normalizeSelectOptions(
52      { options: [{ name: "To Do" }, { name: "Blocked" }, { name: "Done" }] },
53      existing
54    ) as { options: { id: string; name: string }[] };
55    expect(out.options[0].id).toBe(optionIdForName("To Do"));
56    expect(out.options[1].id).toBe("opt-custom-blocked"); // custom id preserved
57    expect(out.options[2].id).toBe(optionIdForName("Done")); // new → deterministic
58  });
59 
60  it("passes through non-select configs (no options array) unchanged", () => {
61    const cfg = { format: "currency", currency: "USD" };
62    expect(normalizeSelectOptions(cfg)).toBe(cfg);
63    expect(normalizeSelectOptions(null)).toBe(null);
64    expect(normalizeSelectOptions(undefined)).toBe(undefined);
65    expect(normalizeSelectOptions({})).toEqual({});
66  });
67 
68  it("does not mutate the input", () => {
69    const cfg = { options: [{ name: "To Do", color: "default" }] };
70    const before = JSON.stringify(cfg);
71    normalizeSelectOptions(cfg);
72    expect(JSON.stringify(cfg)).toBe(before);
73  });
74});
75